Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: remove variable redeclaration #4977

Closed
wants to merge 1 commit into from
Closed

repl: remove variable redeclaration #4977

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2016

match and filter are declared twice with var in repl.js. Declare the variables only once.

@Trott
repl: remove variable redeclaration
a2b4b69 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.
@Trott Trott added repl Issues and PRs related to the REPL subsystem. lts-watch-v4.x labels Jan 30, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 30, 2016

LGTM if CI is ok with it.

@Trott
Copy link
Member Author

Trott commented Jan 30, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1447/

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
@Trott @jasnell
repl: remove variable redeclaration
ba81d15 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

Landed in ba81d15

@jasnell jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott @rvagg
repl: remove variable redeclaration
2844cc0 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@Trott
repl: remove variable redeclaration
718e4b7 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
repl: remove variable redeclaration
18542c4 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
repl: remove variable redeclaration
ff75772 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
repl: remove variable redeclaration
5bcb3be 
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: nodejs#4977
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the repl-no-redeclare branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @mscdex @jasnell @MylesBorins